Deinitialize all the keys instead of just the first one #5312
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Dec 11, 2025
Member
|
@swift-ci please test |
Member
|
@swift-ci please test Windows platform |
parkera
approved these changes
Dec 16, 2025
parkera
reviewed
Dec 16, 2025
| keyArray.append(key) | ||
| } | ||
| keys.deinitialize(count: 1) | ||
| keys.deinitialize(count: count) |
Contributor
There was a problem hiding this comment.
Are we also missing a call to actually initialize the keys? I'm not sure what it means to deinitialize anything at all without first initializing it.
It's probably true that in practice it is not necessary to deinitialize raw pointers at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.