Skip to content

[lldb][swift] ] Fix GetParentIfClosure for didSet/settters/getters #10954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: swift/release/6.2
Choose a base branch
from
Open

[lldb][swift] ] Fix GetParentIfClosure for didSet/settters/getters #10954

wants to merge 2 commits into from

Conversation

felipepiovezan
Copy link

rdar://154313357

@felipepiovezan
[lldb][swift] Fix GetParentIfClosure for getter/setter of computed p…
97e4c9c 
…roperties

 Like previous cases, this requires supporting a few more mangling node
 Kinds.
@felipepiovezan felipepiovezan requested a review from a team as a code owner July 3, 2025 16:34
@felipepiovezan
[lldb][swift] Fix GetParentIfClosure for didSet of properties
f8d883a 
Like previous cases, this requires supporting a few more mangling node
Kinds. This one also requires a separate test Struct/Class because a
`didSet` is not allowed to co-exist with a custom setter.
@felipepiovezan felipepiovezan force-pushed the felipe/fix_diagnostic_2 branch from 61188ee to f8d883a Compare July 3, 2025 16:35
@felipepiovezan
Copy link
Author

@swift-ci test

@felipepiovezan
Copy link
Author

@swift-ci test windows platform

@felipepiovezan
Copy link
Author

Windows failed on:

13:16:57  Failed Tests (2):
13:16:57    Swift(windows-x86_64) :: IRGen/async/run-call-classinstance-void-to-void.sil
13:16:57    Swift(windows-x86_64) :: ModuleInterface/swift_build_sdk_interfaces/find-modules.test-sh
13:16:57

unclear if this is a known issue, but it is unrelated to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-prantl adrian-prantl adrian-prantl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipepiovezan @adrian-prantl