[BoundsSafety] Keep new function type if merged with implicit decl #10845
+41
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In BoundsSafety, we allow merging bounds attributes between function decls if the old decl is implicit. This enables us to add bounds attributes to a function decl if the old one is implicit without causing 'incompatible function decl' error. For example, we can redeclare the implicit decl of `memcmp`, and add `__sized_by()` attributes to its parameters. In attribute-only mode, those attributes are sugars though, and compatible function decls are merged by `Context.mergeTypes()`, which drops those sugars. If both canonical types are the same, we can keep the new type to retain sugars. rdar://152192125
patrykstefanski
requested review from
delcypher,
hnrklssn,
rapidsna and
apple-fcloutier
patrykstefanski
added
the
clang:bounds-safety
|
@swift-ci test llvm |
|
Are we planning to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BoundsSafety, we allow merging bounds attributes between function decls if the old decl is implicit. This enables us to add bounds attributes to a function decl if the old one is implicit without causing 'incompatible function decl' error. For example, we can redeclare the implicit decl of
memcmp, and add__sized_by()attributes to its parameters.In attribute-only mode, those attributes are sugars though, and compatible function decls are merged by
Context.mergeTypes(), which drops those sugars. If both canonical types are the same, we can keep the new type to retain sugars.rdar://152192125