Skip to content

Cherry pick prefix mapping option fix from next #10740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: swift/release/6.2
Choose a base branch
from

Conversation

sina-mahdavi
Copy link

@sina-mahdavi sina-mahdavi commented May 23, 2025

  • Explanation: Add a new prefix mapping option format -fdepscan-prefix-map <old> <new> because the previous format could not handle paths including an equal sign. Made the old format driver-only so it gets translated to the new format when emitting the frontend command.

  • Scope: This should not cause any backward compatibility issues since the old option format is still supported. Only some tests needed to change because they were searching the generated frontend command for the old flag format or they were directly running a frontend command with the old format.

  • Issues: rdar://129434789

  • Original PRs: New option format for prefix mapping #10723

  • Risk: Low, only adds a new flag.

  • Testing: I added a unit test to test the transformPairs function used to construct the prefix mapping objects, as well as a clang driver test to check that the ordering is handled correctly when using a mix of the old and new flag formats. Old tests have been updated to make sure they don't cause false positives with the old format being driver-only now.

  • Reviewers: @akyrtzi @cachemeifyoucan @benlangmuir

@sina-mahdavi sina-mahdavi requested a review from a team as a code owner May 23, 2025 18:02
@sina-mahdavi sina-mahdavi force-pushed the sina-mahdavi/cherry-pick-prefix-mapping-option-PR branch from 9a395a5 to 7b6eb6c Compare May 23, 2025 21:03
@cachemeifyoucan
Copy link

@swift-ci please test

@benlangmuir
Copy link

@swift-ci please test llvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants