Skip to content

[clang][Modules] Adding C-API for Negative Stat Caching Diagnostics #10524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 1, 2025

Conversation

qiongsiwu
Copy link

@qiongsiwu qiongsiwu commented Apr 22, 2025

llvm#135703 added a C++ API to the shared cached to diagnose invalid negatively stat cached paths. This PR adds a C API so an external system can take advantage of the diagnostics.

rdar://149147920

@qiongsiwu
Copy link
Author

qiongsiwu commented Apr 22, 2025

Note to reviewers:
The test added here is simply testing that the API is called correctly. llvm#135703 has a test to test for correctly producing the paths. I am not aware of a simple way to test the C-API for its content (i.e. creating a scan where some file s created in the middle to invalidate the negative stat cache). If you are aware of such tests, I am all ears.

Thanks!

@qiongsiwu qiongsiwu requested review from Bigcheese and jansvoboda11 and removed request for Bigcheese April 22, 2025 20:03
@qiongsiwu qiongsiwu requested a review from jansvoboda11 April 24, 2025 17:07
@qiongsiwu qiongsiwu requested a review from jansvoboda11 April 24, 2025 20:58
@qiongsiwu
Copy link
Author

Ping for review. Thanks!

@qiongsiwu qiongsiwu requested a review from jansvoboda11 April 29, 2025 17:08
@qiongsiwu
Copy link
Author

Ping for review. Thanks!

@qiongsiwu
Copy link
Author

@swift-ci please test llvm

@qiongsiwu
Copy link
Author

The test failures are not related to this PR.

@qiongsiwu qiongsiwu merged commit b7aa45c into swiftlang:next May 1, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants