Skip to content

Rename Tests' timeout() function #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2025
Merged

Rename Tests' timeout() function #555

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fbec1d
rename test function `timeout` to `withTimeout`
sebsto Sep 1, 2025
2c638f2
fix typo
sebsto Sep 1, 2025
9c1641d
Merge branch 'main' into sebsto/timeout
sebsto Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/AWSLambdaRuntime/LambdaRuntimeClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ private final class LambdaChannelHandler<Delegate: LambdaChannelHandlerDelegate>
"user-agent": .userAgent,
"Lambda-Runtime-Function-Response-Mode": "streaming",
// these are not used by this runtime client at the moment
// FIXME: the eror handling should inject these headers in the streamed response to report mid-stream errors
// FIXME: the error handling should inject these headers in the streamed response to report mid-stream errors
"Trailer": "Lambda-Runtime-Function-Error-Type, Lambda-Runtime-Function-Error-Body",
]
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/AWSLambdaRuntimeTests/LambdaRuntimeClientTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ struct LambdaRuntimeClientTests {
// simulate traffic until the server reports it has closed the connection
// or a timeout, whichever comes first
// result is ignored here, either there is a connection error or a timeout
let _ = try await timeout(deadline: .seconds(1)) {
let _ = try await withTimeout(deadline: .seconds(1)) {
while true {
let (_, writer) = try await runtimeClient.nextInvocation()
try await writer.writeAndFinish(ByteBuffer(string: "hello"))
Expand Down
2 changes: 1 addition & 1 deletion Tests/AWSLambdaRuntimeTests/Timeout.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
//===----------------------------------------------------------------------===//

// as suggested by https://github.com/vapor/postgres-nio/issues/489#issuecomment-2186509773
func timeout<Success: Sendable>(
func withTimeout<Success: Sendable>(
deadline: Duration,
_ closure: @escaping @Sendable () async throws -> Success
) async throws -> Success {
Expand Down