Test update swift_cc_test_library [AP-3450]
#153
Draft
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armallen
changed the title
swift_cc_test_libraryswift_cc_test_library [AP-3450]
armallen
commented
May 7, 2025
| kwargs["copts"] = local_includes + kwargs.get("copts", []) | ||
| standard = kwargs.pop("standard", None) | ||
|
|
||
| copts = _common_cc_opts(nocopts, pedantic = False) |
There was a problem hiding this comment.
pedantic = False is important, this is a test library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
standardoption toswift_cc_test_libraryA fix is needed in starling, a
swift_cc_test_librarycall is done oncsources: https://github.com/swift-nav/starling/pull/9852Test
rules_swiftnavupdate in orion-engine: https://github.com/swift-nav/orion-engine/pull/9439