Update game data items constants - #95
Merged
Merged
Conversation
github-actions
Bot
added
dependencies
MarTrepodi
added
code maintenance
MarTrepodi
enabled auto-merge (squash)
June 3, 2026 17:06
Add Python 3.14 to the ci.yml test matrix so CI verifies the package runs on the latest stable interpreter, and add the corresponding "Programming Language :: Python :: 3.14" trove classifier so PyPI metadata accurately reflects supported versions. `requires-python = ">=3.10"` already covers 3.14, and the ruff `target-version = "py310"` / mypy `python_version = "3.10"` settings are floor values so they need no update. Branch protection on main has also been updated separately to require the new `Test (Python 3.14)` status check. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ion test The comlink server rejects raw single-bit item values (HTTP 400) with a message recommending Segment1-4. Switch the filtered get_game_data integration test from DataItems.UNITS to DataItems.SEGMENT1 so it runs against a value the server accepts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
ci
4 tasks
MarTrepodi
added a commit
that referenced
this pull request
Jun 3, 2026
## Summary - Update `DataItems` docstring, `docs/api/helpers.md`, and the Sync/Async `examples/get_game_data.py` scripts to use the server-accepted `SEGMENT1`–`SEGMENT4` aggregates instead of raw single-collection bit values (`DataItems.UNITS`, `"UnitDefinitions"`). The Comlink server validates `items` against its `GameDataItemsEnum` and rejects single-bit values with HTTP 400 — same root cause as the integration test fix in #95. - Add a new "GameDataItems server alignment" section (§9) to `docs/migration.md` covering the `Segment2` (`68717379584` → `1125968624222208`) and `Segment4` (`281200098803712` → `3377424842620928`) aggregate value changes, the new `DataItems` members (`ABILITY_DECISION_TREE`, `ERA_DEFINITION`, `UBS_UPDATE`), and the new legacy-name aliases. Updates the migration summary table to reflect the same. - Fix a pre-existing typo in `docs/migration.md` where `Constants.get("Segment1")` was annotated as returning `'206158430208'` (Segment3's value) — it actually returns `'2097151'`. ## Dependencies Built on top of #95. The helper symbols this PR documents (`DataItems.ABILITY_DECISION_TREE`, etc., and the corrected `SEGMENT2`/`SEGMENT4` values) land in #95. Recommend merging #95 first; this branch will then rebase cleanly onto `main` and the diff will narrow to docs-only. ## Test plan - [x] `uv run mkdocs build --strict` builds clean (new `#9-gamedataitems-server-alignment` anchor resolves) - [x] `uv run ruff format` / `uv run ruff check` clean on the edited source file - [x] `uv run pytest tests/unit/test_helpers.py -k "Constants or GameDataItemsEnumSync"` — 12 passed - [ ] CI green on push (after #95 merges and this rebases) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the game data
itemsconstants with latest values from ComlinkType of Change
Checklist
feat:,fix:,refactor:, etc.)python -m pytest tests/ -v)ruff check src/ tests/)