Skip to content

fix(tests): switch HMAC rejection tests from GET to POST endpoint #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarTrepodi merged 1 commit into from
May 10, 2026
Merged

fix(tests): switch HMAC rejection tests from GET to POST endpoint #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 29 additions & 8 deletions tests/integration/test_hmac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
COMLINK_HMAC_URL,
HMAC_ACCESS_KEY,
HMAC_SECRET_KEY,
TEST_ALLYCODE,
)

pytestmark = pytest.mark.integration
Expand Down Expand Up @@ -48,14 +49,24 @@ def test_hmac_sync_player_request_succeeds(comlink_hmac):

@hmac_configured
def test_hmac_no_key_rejected():
"""Sync client without HMAC keys is rejected by the protected endpoint."""
"""Sync client without HMAC keys is rejected by the protected endpoint.

Uses a POST endpoint (`playerArena`) because the Comlink HMAC service
only enforces HMAC on POST; GET endpoints like `/enums` are
unauthenticated.
"""
with SwgohComlink(url=COMLINK_HMAC_URL) as client, pytest.raises(SwgohComlinkException):
client.get_enums()
client.get_player_arena(allycode=TEST_ALLYCODE, player_details_only=True)


@hmac_configured
def test_hmac_wrong_key_rejected():
"""Sync client with wrong secret key is rejected by the protected endpoint."""
"""Sync client with wrong secret key is rejected by the protected endpoint.

Uses a POST endpoint (`playerArena`) because the Comlink HMAC service
only enforces HMAC on POST; GET endpoints like `/enums` are
unauthenticated.
"""
with (
SwgohComlink(
url=COMLINK_HMAC_URL,
Expand All @@ -64,7 +75,7 @@ def test_hmac_wrong_key_rejected():
) as client,
pytest.raises(SwgohComlinkException),
):
client.get_enums()
client.get_player_arena(allycode=TEST_ALLYCODE, player_details_only=True)


# ── Async: valid HMAC ───────────────────────────────────────────────────
Expand Down Expand Up @@ -94,23 +105,33 @@ async def test_hmac_async_player_request_succeeds(async_comlink_hmac):
@hmac_configured
@pytest.mark.asyncio
async def test_hmac_no_key_async_rejected():
"""Async client without HMAC keys is rejected by the protected endpoint."""
"""Async client without HMAC keys is rejected by the protected endpoint.

Uses a POST endpoint (`playerArena`) because the Comlink HMAC service
only enforces HMAC on POST; GET endpoints like `/enums` are
unauthenticated.
"""
async with SwgohComlinkAsync(url=COMLINK_HMAC_URL) as client:
with pytest.raises(SwgohComlinkException):
await client.get_enums()
await client.get_player_arena(allycode=TEST_ALLYCODE, player_details_only=True)


@hmac_configured
@pytest.mark.asyncio
async def test_hmac_wrong_key_async_rejected():
"""Async client with wrong secret key is rejected by the protected endpoint."""
"""Async client with wrong secret key is rejected by the protected endpoint.

Uses a POST endpoint (`playerArena`) because the Comlink HMAC service
only enforces HMAC on POST; GET endpoints like `/enums` are
unauthenticated.
"""
async with SwgohComlinkAsync(
url=COMLINK_HMAC_URL,
access_key=HMAC_ACCESS_KEY,
secret_key="wrong_secret_key",
) as client:
with pytest.raises(SwgohComlinkException):
await client.get_enums()
await client.get_player_arena(allycode=TEST_ALLYCODE, player_details_only=True)


# ── HMAC header verification ────────────────────────────────────────────
Expand Down
Loading