Skip to content

fix(helpers): include unit name keys with variant suffixes like _NAME_V2 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarTrepodi merged 1 commit into from
Sep 1, 2026
Merged

fix(helpers): include unit name keys with variant suffixes like _NAME_V2 #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/swgoh_comlink/helpers/_game_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ def create_localized_unit_name_dictionary(locale: str | list[Any]) -> dict[str,
if line.startswith("#") or "|" not in line:
continue
if line.startswith("UNIT_"):
name_key, desc = line.split("|")
if name_key.endswith("_NAME"):
name_key, desc = line.split("|", 1)
if "_NAME" in name_key:
unit_name_map[name_key] = desc
return unit_name_map

Expand Down
14 changes: 14 additions & 0 deletions tests/unit/test_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,20 @@ def test_bytes_in_list(self):
result = create_localized_unit_name_dictionary(locale_list)
assert result == {"UNIT_LUKE_NAME": "Luke Skywalker"}

def test_name_variant_suffixes_included(self):
from swgoh_comlink.helpers._game_data import create_localized_unit_name_dictionary

locale_list = [
"UNIT_JEDIKNIGHTREVAN_NAME_V2|Jedi Knight Revan",
"UNIT_BOSSK_NAME|Bossk",
"UNIT_BOSSK_DESC|A hunter",
]
result = create_localized_unit_name_dictionary(locale_list)
assert result == {
"UNIT_JEDIKNIGHTREVAN_NAME_V2": "Jedi Knight Revan",
"UNIT_BOSSK_NAME": "Bossk",
}

def test_comments_and_non_unit_lines_skipped(self):
from swgoh_comlink.helpers._game_data import create_localized_unit_name_dictionary

Expand Down
Loading