fix(deps): floor all three brace-expansion majors on their complete fixes - #113
Merged
Conversation
…ixes Ports apple-mail-mcp#123 here, and closes the gap it could not: mail resolves only two brace-expansion majors, this repo resolves three, and two of its four resolved paths sat below even the advisory's own floor. Before: 1.1.16 2.1.x 5.0.7 5.0.8 After: 1.1.18 2.1.4 5.0.9 GHSA-mh99-v99m-4gvg / CVE-2026-14257 (high). The advisory's first-patched versions bound the accumulator in combine() but never thread maxLength into expandSequence(), so the sequence path stays capped only by item count. The complete fixes (1.1.18 / 2.1.4 / 5.0.9) add the missing bound. Each major is floored separately because they are not API-compatible -- minimatch@3 needs the v1 CommonJS API, so one floor spanning all three fails with "expand is not a function". The bounds are two-sided: a bare "<5.0.9" also matches 1.1.18 and 2.1.4 under semver. Verified against each lockfile's own `overrides:` section, the only positive evidence an override is live -- pnpm has never read npm's bare top-level `overrides` field and warns about nothing when one is inert. Dev toolchain only; brace-expansion is not in the shipped bundle. Committed bundle verified byte-identical after a rebuild, so no version bump is owed.
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports apple-mail-mcp#123 here — and closes the gap that PR could not see. mail resolves only two
brace-expansionmajors; this repo resolves three, and two of its four resolved paths sat below even the advisory's own floor.eslint→minimatch@3)1.1.16— unpatched1.1.18minimatch@9)2.1.32.1.4minimatch@10.2.5/10.2.6)5.0.7— unpatched /5.0.85.0.9Why the advisory's own floor isn't enough
GHSA-mh99-v99m-4gvg / CVE-2026-14257 (high). The first-patched versions (
1.1.17/2.1.3/5.0.8) bound the accumulator incombinebut never threadmaxLengthintoexpandSequence, so the sequence path ({1..N},{a..z..k}) stays capped only by item count:A padded sequence therefore still materialises ~100,000 intermediate strings before the outer bound truncates — 4,606 ms / 176 MB RSS on
1.1.17vs 9 ms / 61 MB on1.1.18, for byte-identical final output.1.1.18/2.1.4/5.0.9add the missing bound; verified by diffing the published tarballs, not by reading the advisory text.Why three separate two-sided floors
The majors are not API-compatible:
minimatch@3requires the v1 CommonJS API, so one floor spanning all three fails withexpand is not a function. And the bounds must be two-sided — a bare<5.0.9also matches1.1.18and2.1.4under semver, which would drag the CommonJS path onto the v5 ESM API.Verified against the lockfile's own
overrides:section, the only positive evidence an override is live (pnpm has never read npm's bare top-leveloverridesfield, and warns about nothing when one is inert).Verification
pnpm install→ "Lockfile passes supply-chain policies"; nominimumReleaseAgeExclude, no audit suppression. All three releases cleared the 24 hminimumReleaseAgegate (published 2026-07-30 ~10:00–10:17Z).pnpm run typecheck,pnpm run lint(0 errors),pnpm run format:check,pnpm test— all pass.pnpm run build→ committed bundle byte-identical (SHA-256 unchanged), so no version bump is owed.Dev toolchain only —
brace-expansionis not in the shipped bundle and this repo's runtime dependencies are unaffected, so nothing that ships to npm changes.Thanks to @jjoanna2-debug for the original finding in apple-mail-mcp#119/#121.