docs(scripts): drop the stale .hermes-plugin note from sync-skills.mjs - #110
Merged
Conversation
.hermes-plugin/ no longer exists, so a comment explaining that it "carries no skill copy" now points at nothing and just makes a reader hunt for a directory that was removed. The surviving clause (.agents/plugins/marketplace.json sources ./codex, so syncing codex covers every other surface) is the part that still matters. Comment only — the script's behavior is unchanged and `sync-skills.mjs --check` still passes. scripts/ is not in package.json files[], so nothing ships and no version bump is owed; no CHANGELOG entry for a comment correction. The file stays byte-identical across all four repos (ci.yml verifies skill copies, and conformance-check.sh expects this file to match), so this same commit lands in each.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last remaining reference to the removed
.hermes-plugin/directory. The comment explained that hermes "carries no skill copy" — now that the directory is gone, it only sends a reader looking for something that no longer exists. The clause that still matters (.agents/plugins/marketplace.jsonsources./codex, so syncing codex covers every other surface) is kept.Comment only — script behavior unchanged and
sync-skills.mjs --checkstill passes in all four repos.scripts/is not inpackage.jsonfiles[], so nothing ships: no version bump, and no CHANGELOG entry for a comment correction.The file is byte-identical across all four repos (ci.yml's skill-copy verification and
conformance-check.shboth depend on that), so this identical commit lands in each — verified matching sha256 after the edit.