fix(ci): unbreak the Dependabot auto-bump after the .hermes-plugin removal - #109
Merged
Conversation
…moval
dependabot-rebuild.yml's bump step writes a patch version bump, runs
sync-plugin-version.mjs and prepends a CHANGELOG entry, then staged all of it
with:
git add package.json CHANGELOG.md build .claude-plugin .agents codex \
.hermes-plugin .antigravity-plugin 2>/dev/null || true
`.hermes-plugin/` no longer exists, and `git add` is all-or-nothing: one
pathspec matching nothing makes it exit 128 and stage NONE of the others. The
`2>/dev/null || true` swallowed the exit code but not the consequence — nothing
was staged. The next step re-adds only `build/`, so a Dependabot PR would have
landed a rebuilt bundle with no version bump and no changelog entry, failing
require-version-bump and blocking exactly the automation this workflow exists to
provide.
Two changes:
- drop the stale `.hermes-plugin` path
- drop `2>/dev/null || true` so a future missing path fails the job loudly
rather than silently skipping the bump. Verified all seven remaining paths
exist in all four repos and the unsuppressed `git add` exits 0.
The file stays byte-identical across all four repos (conformance-check.sh);
this same commit lands in each. .github/ does not ship, so no version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dependabot auto-bump is currently broken in all four repos. This is not the cosmetic cleanup it looked like.
dependabot-rebuild.yml's bump step writes a patch version bump, runssync-plugin-version.mjs, prepends a CHANGELOG entry, and then stages all of it with:.hermes-plugin/no longer exists.git addis all-or-nothing: one pathspec matching nothing makes it exit 128 and stage none of the others. The2>/dev/null || trueswallowed the exit code but not the consequence — nothing got staged.The next step (
Commit and push the rebuilt bundle) re-adds onlybuild/. So a Dependabot npm PR whose rebuilt bundle changed would commit the bundle with no version bump and no CHANGELOG entry, then failrequire-version-bump— blocking precisely the automation this workflow exists to provide ("so Dependabot automation flows without a human"). Silently, because the error was suppressed.Changes
.hermes-pluginpath.2>/dev/null || true. That suppression is what let this go unnoticed; the step runs underset -euo pipefail, so a future missing path now fails the job loudly instead of quietly skipping the bump. Verified all seven remaining paths (package.json,CHANGELOG.md,build,.claude-plugin,.agents,codex,.antigravity-plugin) exist in all four repos and the unsuppressedgit addexits 0 in each.Fleet consistency
The four repos keep
dependabot-rebuild.ymlbyte-identical forconformance-check.sh, so this identical commit lands in all four. Verified matchingsha256across all four after the edit, and./conformance-check.shpasses..github/does not ship, so no version bump is owed.