chore(hermes): remove hermes-plugin packaging docs - #107
Merged
Conversation
Propagates apple-mail-mcp#116 (originally @maf4711's apple-mail-mcp#115) to keep multi-host packaging parity across the four Apple MCP servers. Hermes Agent has no plugin/marketplace drop-in, so a directory of manifest-looking files (README.md, config.yaml) was easy to misread as an installable package. Two things the removal requires: - package.json: the `version` lifecycle script listed `.hermes-plugin` in its `git add`. `git add` exits 128 on a pathspec matching nothing, so once the directory is gone `pnpm version <patch|minor|major> --no-git-tag-version` — the documented release step — would fail on every subsequent release. - README: the "Other Hosts" Hermes bullet linked to both deleted files and would have 404'd. The useful content is now inline instead: the `hermes mcp add` command, the `~/.hermes/config.yaml` mcp_servers snippet, and the restart note. Not touched: .github/workflows/dependabot-rebuild.yml also lists .hermes-plugin in a `git add`, but it is guarded by `2>/dev/null || true` so it cannot fail, and the four repos keep that file byte-identical for conformance-check.sh — so it stays as-is in all four rather than drifting here. No version bump: .hermes-plugin/ was never in package.json files[], there is no src/ change, and the committed bundle is byte-identical (verified by rebuild).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagates apple-mail-mcp#116 (originally @maf4711's apple-mail-mcp#115) so multi-host packaging stays consistent across the four Apple MCP servers. mail dropped
.hermes-plugin/today; leaving the other three carrying it would make mail the odd one out with no reason a reader could discover.Hermes Agent has no plugin/marketplace drop-in, so a directory containing
README.md+config.yamlwas easy to misread as an installable package. It was never shipped —.hermes-plugin/is not inpackage.jsonfiles[].Two things the removal requires
pnpm versionwould otherwise break on every future release. Theversionlifecycle script listed the deleted path:git addexits 128 on a pathspec that matches nothing, sopnpm version <patch|minor|major> --no-git-tag-version— the documented release step — would fail as soon as the directory was gone. This was found on mail before it could bite; the same landmine exists here.Dead README links. The "Other Hosts" Hermes bullet linked to both files being deleted, so they would have 404'd. Rather than just dropping the links, the setup content moves inline: the
hermes mcp addcommand, the~/.hermes/config.yamlmcp_servers:snippet, and the restart note. Better placed there anyway — nobody browses a dot-directory for setup instructions.Plus CHANGELOG entries under
[Unreleased].Deliberately not included
.github/workflows/dependabot-rebuild.ymlalso lists.hermes-pluginin agit add, but it is guarded by2>/dev/null || trueso it cannot fail. The four repos keep that file byte-identical forconformance-check.sh, so it stays as-is in all four rather than drifting in one — verified./conformance-check.shstill passes with mail already merged.No version bump
.hermes-plugin/was never inpackage.jsonfiles[], there is nosrc/change, and the committed bundle is byte-identical after a rebuild — nothing that ships to npm changes.require-version-bumppassed on the mail equivalent with the same shape of change.