Skip to content

fix(loader): only doing file I/O once during webpack loader. #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(loader): only doing file I/O once during webpack loader. #755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41191f3
only doing file I/O once during webpack loader.
Feb 9, 2024
a721794
trying to get email to come thru in commit.
Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 31 additions & 16 deletions packages/loader/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,37 @@
import { transform } from '@swc-node/core'
import { transform, Options } from '@swc-node/core'
import { readDefaultTsConfig, tsCompilerOptionsToSwcConfig } from '@swc-node/register/read-default-tsconfig'
import { CompilerOptions, convertCompilerOptionsFromJson } from 'typescript'
import type { LoaderContext } from 'webpack'

let swcConfig: Options

function getSwcConfig(
this: LoaderContext<{
compilerOptions?: CompilerOptions
configFile?: string
fastRefresh?: boolean
}>,
): Options {
if (!swcConfig) {
const { compilerOptions, configFile, fastRefresh } = this.getOptions() ?? {}
const { options: assignedOptions } = convertCompilerOptionsFromJson(compilerOptions, '')
const options =
!assignedOptions || Object.keys(assignedOptions).length === 0 ? readDefaultTsConfig(configFile) : assignedOptions
swcConfig = tsCompilerOptionsToSwcConfig(options, this.resourcePath)
if (fastRefresh) {
if (swcConfig.react) {
swcConfig.react.refresh = true
} else {
swcConfig.react = {
refresh: true,
}
}
}
}

return swcConfig
}

export function loader(
this: LoaderContext<{
compilerOptions?: CompilerOptions
Expand All @@ -12,21 +41,7 @@ export function loader(
source: string,
) {
const callback = this.async()
const { compilerOptions, configFile, fastRefresh } = this.getOptions() ?? {}
const { options: assignedOptions } = convertCompilerOptionsFromJson(compilerOptions, '')
const options =
!assignedOptions || Object.keys(assignedOptions).length === 0 ? readDefaultTsConfig(configFile) : assignedOptions
const swcOptions = tsCompilerOptionsToSwcConfig(options, this.resourcePath)
if (fastRefresh) {
if (swcOptions.react) {
swcOptions.react.refresh = true
} else {
swcOptions.react = {
refresh: true,
}
}
}
transform(source, this.resourcePath, swcOptions)
transform(source, this.resourcePath, getSwcConfig.call(this))
.then(({ code, map }) => callback(null, code, map))
.catch((err) => callback(err))
}