Skip to content

[Java] add API helper function to Java and Add licenseInfo to all Java lib template #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shijinkui
Copy link
Contributor

@shijinkui shijinkui commented Jan 16, 2018

PR checklist

Description of the PR

  1. delete blank line between license and package line
  2. add {{>licenseInfo}} to all class file
  3. generate java-petstore
  4. add function setApiEndpoint(String apiEndpoint) in java/api.mustache
    like: private final ClusterApi api = new ClusterApi().setApiEndpoint("https://xxx.com");

cc @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet

1. delete blank line between license and `package` line
2. add `{{>licenseInfo}}` to all class file
3. generate java-petstore
4. add function `setApiEndpoint(String apiEndpoint)` in `java/api.mustache`
   like: `private final ClusterApi api = new ClusterApi().setApiEndpoint("https://xxx.com");`
	./bin/scala-petstore.sh
	./bin/akka-scala-petstore.sh
	./bin/scala-lagom-server-petstore.sh
	./bin/scalatra-petstore-server.sh
	./bin/scalaz-petstore.sh
	./bin/akka-scala-petstore.sh
	./bin/java-play-framework-petstore-server-all.sh
	./bin/android-petstore-all.sh
	./bin/kotlin-client-petstore.sh
@wing328
Copy link
Contributor

wing328 commented Jan 22, 2018

add function setApiEndpoint(String apiEndpoint) in java/api.mustache
like: private final ClusterApi api = new ClusterApi().setApiEndpoint("https://xxx.com");

Please do this in a separate PR.

I believe it's currently doable with the Configuration class without introducing the setApiEndpoint method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants