dhcp: fix typing #1300
Merged
dhcp: fix typing #1300
+28
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svinota
reviewed
Feb 25, 2025
| callback=lambda: asyncio.create_task( | ||
| callback(signal=signal) # type: ignore[arg-type] | ||
| ), | ||
| callback=lambda: asyncio.create_task(callback(signal=signal)), |
svinota
reviewed
Feb 25, 2025
| @@ -49,7 +47,7 @@ def arm(self, lease: Lease, **callbacks: AsyncCallback) -> None: | |||
| loop = asyncio.get_running_loop() | |||
|
|
|||
| for timer_name, async_callback in callbacks.items(): | |||
| self._reset_timer(timer_name) # type: ignore[arg-type] | |||
| self._reset_timer(timer_name) | |||
There was a problem hiding this comment.
Not sure if it is a good idea to add some CI test that raises warnings if there are any inline linter overrides.
There was a problem hiding this comment.
as long as it does not make the CI fail, i see no issue with it !
There was a problem hiding this comment.
If it doesn't break the CI, what's the point in having it there? :))) But you're right, it might be a bit too much. Oke, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.