-
-
Notifications
You must be signed in to change notification settings - Fork 117
feat: enable optimizer for server environments during dev #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Tee Ming <[email protected]>
Co-authored-by: Tee Ming <[email protected]>
if (config.consumer === 'server' && optimizeDeps !== undefined) { | ||
// optimizeDeps is not inherited by server environments so return it here | ||
return { | ||
optimizeDeps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not entirely happy with this for 2 reasons
-
this configuration part should probably be moved out of this plugin and into the setup-optimizer plugin, but that requires a bit of refactoring and maybe running vitefu twice.
-
it replicates the same optimizeDeps for server and client env, but i am not sure yet if the same rules apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it replicates the same optimizeDeps for server and client env, but i am not sure yet if the same rules apply
I was thinking the same thing. Would it be enough for us to just configure the extensions
and plugins
settings so that esbuild knows how to handle Svelte modules? Then, the user can decide what to include/exclude for optimizing themselves.
No description provided.