fix: adjust loc property of Program nodes created from <script> elements
#17428
+40
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the
locof the instance/moduleProgramto correspond to the inside of the<script>tag, rather than always being0.Though I've just realised that this won't actually fix the related issue (#17003) because the problem is the end rather than the start — may need to come up with a different solution.Fixes #17003The nub of the problem is this — we're setting the bounds of the default-export function body to the bounds of the instance
Programso that comments are inserted correctly:svelte/packages/svelte/src/compiler/phases/3-transform/client/transform-client.js
Lines 401 to 402 in 1482ae8
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint