Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-turtles-yell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: flush pending changes after rendering `failed` snippet
2 changes: 1 addition & 1 deletion packages/svelte/src/internal/client/dom/blocks/boundary.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import {
skip_nodes,
set_hydrate_node
} from '../hydration.js';
import { get_next_sibling } from '../operations.js';
import { queue_micro_task } from '../task.js';
import * as e from '../../errors.js';
import * as w from '../../warnings.js';
Expand Down Expand Up @@ -409,6 +408,7 @@ export class Boundary {
if (failed) {
queue_micro_task(() => {
this.#failed_effect = this.#run(() => {
Batch.ensure();
this.#is_creating_fallback = true;

try {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { tick } from 'svelte';
import { test } from '../../test';

export default test({
async test({ assert, target, logs }) {
const btn = target.querySelector('button');
btn?.click();
await tick();

assert.deepEqual(logs, ['attachment']);
}
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<script>
let fail = $state(false);

function error() {
throw new Error('oops');
}

function attachment() {
console.log('attachment');
}
</script>

<svelte:boundary>
{fail ? error() : 'all good'}
<button onclick={() => fail = true}>fail</button>

{#snippet failed()}
<div {@attach attachment}>oops!</div>
{/snippet}
</svelte:boundary>
Loading