-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: add source name logging to $inspect.trace
#16060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 4047913 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
What does |
I removed the |
Is that desirable? In the very rare case that two sources share a single proxy, replacing If we get rid of |
…combining tag and tag_proxy)
* remove PROXY_REMOVE_PATH * simplify a bit * simplify * tweak * tweak implementation * tweak implementation * tweak implementation * hoist * tweak * fix * WIP (reduce number of with_parent calls, move towards possibility of combining tag and tag_proxy) * DRY out
This is a huge improvement! Makes Also, I broke the tests when I swapped the labels around — fixing |
This adds name logging to
$inspect.trace
. Currently,$inspect.trace
logs the type of dependency ($state
or$derived
), its current value, and a few stack traces related to it. In this PR, to better understand your dependencies, it includes the name of each dependency— if it's a variable, it'll log its name, and if it's an object property, it'll log the path (egobject.foo.bar.baz[0]
).Probably closes #15954
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint