feat: attachments fromAction
utility
#15933
Open
+257
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a way to convert from action to attachments...this is useful if you are using a library that provides actions (like melt) and you want to spread them in dumb components.
There's a slight type issue at the moment: if you have an optional argument to the action you will need to pass the second argument... I was not able to fix this yet but since I'm not sure if this will actually be merged I decided to put it out there to discuss and maybe someone better than me at TS will be able to fix it (or I'll fix it later since i have to go now)
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint