-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: spreading style is not consistent with attribute #15323
Conversation
🦋 Changeset detectedLatest commit: c3934d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@@ -224,15 +224,17 @@ export function set_custom_element_data(node, prop, value) { | |||
set_active_effect(null); | |||
try { | |||
if ( | |||
// style need set_attribute() | |||
prop !== 'style' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that is necessary, was it reall inconsistent before? Also see my question in the related issue
I wonder if we should go the other way, i.e. always use <script>
let { style = 'invalid-key:0; margin:4px;;color: green ;color:blue ' } = $props();
</script>
<div {style}></div>
<div {...{style}}></div>
<div {style} style:padding={0}></div>
<div {...{style}} style:padding={0}></div> ...results in this: <div style="invalid-key:0; margin:4px;;color: green ;color:blue "></div>
<div style="invalid-key:0; margin:4px;;color: green ;color:blue "></div>
<div style="margin: 4px; color: blue; padding: 0px;"></div>
<div style="margin: 4px; color: blue; padding: 0px;"></div> Feels like if we're making this change for the sake of consistency, we should go all the way. In microbenchmark conditions it's slightly slower to use |
Ah, I see — it makes SSR/hydration more finicky, at least as far as the tests are concerned |
When we pass the style value directly,
set_attribute()
is used.But with spreading, it was set by an assign on
element.style.cssText
(ornode[prop]
for custom-element).This cause the text to be parsed/corrected by the browser, and the value of the attribute will be different.
With this fix, spreading also use
set_attribute()
for style.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint