Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warning issues with peer dependencies #2409

Closed
wants to merge 2 commits into from

Conversation

delight
Copy link

@delight delight commented Jun 21, 2024

Allow svelte-preprocess ^6 to avoid warnings when using the latest dependencies.

 WARN  Issues with peer dependencies found
.
└─┬ svelte-check 3.8.1
  └─┬ svelte-preprocess 5.1.4
    └── ✕ unmet peer postcss-load-config@"^2.1.0 || ^3.0.0 || ^4.0.0 || ^5.0.0": found 6.0.1

Allow  svelte-preprocess ^6 to avoid warnings when using the latest dependencies.

```
 WARN  Issues with peer dependencies found
.
└─┬ svelte-check 3.8.1
  └─┬ svelte-preprocess 5.1.4
    └── ✕ unmet peer postcss-load-config@"^2.1.0 || ^3.0.0 || ^4.0.0 || ^5.0.0": found 6.0.1
```
dummdidumm
dummdidumm previously approved these changes Jun 24, 2024
@dummdidumm dummdidumm dismissed their stale review June 24, 2024 08:23

it's a dependency, not a peer dep

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do this because it's a dependency, and that dependency requires node 18, while we claim node 16 still. But we'll do a new major of svelte-check soon where we can include this.

@dummdidumm
Copy link
Member

Closing in favor of #2401

@dummdidumm dummdidumm closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants