Skip to content

fix: construct query params from location.search on rehydrate #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: construct query params from location.search on rehydrate #1511

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa4fedd
fix: on rehydrate, when page has no query params, construct them from…
May 29, 2021
f2c3b36
simplified to only use location.search
May 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/server/page/render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export async function render_response({
page: {
host: ${page.host ? s(page.host) : 'location.host'}, // TODO this is redundant
path: ${s(page.path)},
query: new URLSearchParams(${s(page.query.toString())}),
query: new URLSearchParams(location.search),
params: ${s(page.params)}
}
}` : 'null'}
Expand Down