Skip to content

Conversation

@paoloricciuti
Copy link
Member

Closes #14515

TBF this seems like a bug in vite rather than something we should work around here, but I wasn't able to create a minimal repro so in the meantime I'll open this PR and we can discuss.

Basically what happens is that if a client module and a server module import the same remote function during preloading, the module will basically be requested at the same time. This confuses vite and the self_import contains all the exports as undefined, triggering the error within init_remote_functions. If the module is imported by itself, this error doesn't occur.

I can spend a bit more time trying to figure out if that's an actual vite issue or if someone has better ideas we can implement those, but this feels like a simple easy fix that it's not too heavy considering it's only in dev.

I really have no idea how to test this tho 😬

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025

🦋 Changeset detected

Latest commit: d22a9ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive remote export is invalid error

2 participants