Skip to content

Conversation

@Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Oct 22, 2025

WIP. counterpart to sveltejs/svelte#17004


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

🦋 Changeset detected

Latest commit: 66761b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

Alright, I think this is ready. No tests because I'm under time pressure... and in any case we will likely want to overhaul the implementation for SvelteKit 3, as things will look different (and more fine-grained) in future. For example we will be able to maintain multiple forks simultaneously, rather than being limited to one as we are today.

But I've tested locally and it works beautifully

};

if (svelte.fork) {
load_cache.fork = load_cache.promise.then((result) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is waiting for promise to assign to load_cache.fork but in promise we could call discard_load_cache that should clear load_cache.fork in case of an error. Wouldn't this leak fork in case of an error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh great catch! pushed a fix

@Rich-Harris Rich-Harris merged commit f91fd47 into main Oct 26, 2025
22 checks passed
@Rich-Harris Rich-Harris deleted the fork-me branch October 26, 2025 18:35
@github-actions github-actions bot mentioned this pull request Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants