Skip to content

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Oct 22, 2025

fixes #14785

This PR changes the client-side resolve implementation to take into account the hash router setting. As a result, it'll add a hash so you get a route such as /base#/my-route which is what you want when hash routing is enabled.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

🦋 Changeset detected

Latest commit: 4318d08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dummdidumm dummdidumm merged commit cd72d94 into main Oct 28, 2025
22 checks passed
@dummdidumm dummdidumm deleted the fix-resolve-hash-routing branch October 28, 2025 21:58
@github-actions github-actions bot mentioned this pull request Oct 28, 2025
gwennlbh added a commit to cigaleapp/cigale that referenced this pull request Nov 3, 2025
might wanna just use sveltekit resolve() directly in the future

see github.com/sveltejs/kit/pull/14786/
renovate bot added a commit to cigaleapp/cigale that referenced this pull request Nov 3, 2025
* ⬆️ Update dependency @sveltejs/kit to ^2.48.4

* update $lib/paths:href to just use resolve()

might wanna just use sveltekit resolve() directly in the future

see github.com/sveltejs/kit/pull/14786/

* fix root redirect

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Gwenn Le Bihan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resolve() does not account for kit.router.type: 'hash'

3 participants