-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Improve external dependency handling for non-standard project structures (adapter-node) #13796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
New features should include an explanation of why they are necessary (why does your |
In my specific case, I'm not just working with an one SvelteKit application, and I can't use a monorepo approach (it would add unnecessary complexity). Everything works perfectly until it gets to the build stage. The adapter fails with an error because it can't find the package.json which is located one level up. The adapter definitely shouldn't prevent us from having structure like
|
Please open an issue with a reproduction of your problem. |
The problem is that the adapter's code hardcodes the path to package.json when parsing dependencies. When the project has this structure:
the build fails with an error since it can't locate the package.json file |
There's still not really enough information here to understand your problem. This should really include an issue with a reproduction |
This PR enhances the Rollup configuration to better handle projects where package.json isn't located in the same directory (my case).
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits