-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to vitest 3 #13330
chore: upgrade to vitest 3 #13330
Conversation
|
preview: https://svelte-dev-git-preview-kit-13330-svelte.vercel.app/ this is an automated message |
716c138
to
3098758
Compare
Ran it locally and it takes just a little over 5000ms for that test to run so it fails due to the default 5000ms timeout limit (similar to the CI failure). Is it worth further investigation or should we just increase the timeout limit for that test so it can pass?
|
We should just increase it a bit, there's nothing really that changed here over the last months |
It's a bit weird that it's timing out consistently with Vite 3 and wasn't with Vite 2. We should probably check that the test suite as a whole isn't taking a lot longer to run. But I guess if it's about the same overall there's no harm in bumping it |
The test takes the same amount of time if not slightly longer with Vitest 2 (5400ms) https://github.com/sveltejs/kit/actions/runs/12821853458/job/35753837184?pr=13227#step:9:49 not sure why the timeout error only kicks in for Vitest 3 |
Weird, yeah, it looks like Vitest 2 was just ignoring the timeout. I had to bump it a bunch of places to get things passing. It's working now |
Most tests passing now with 3.0.1
Don't merge until all are passing though. The Windows test failure appears to be persistent