Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to vitest 3 #13330

Merged
merged 6 commits into from
Jan 20, 2025
Merged

chore: upgrade to vitest 3 #13330

merged 6 commits into from
Jan 20, 2025

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Jan 16, 2025

Most tests passing now with 3.0.1

Don't merge until all are passing though. The Windows test failure appears to be persistent

Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: e1d253a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13330-svelte.vercel.app/

this is an automated message

@eltigerchino
Copy link
Member

eltigerchino commented Jan 17, 2025

Ran it locally and it takes just a little over 5000ms for that test to run so it fails due to the default 5000ms timeout limit (similar to the CI failure). Is it worth further investigation or should we just increase the timeout limit for that test so it can pass?

test timed out

test('Creates correct $types', () => {

@dummdidumm
Copy link
Member

We should just increase it a bit, there's nothing really that changed here over the last months

@benmccann
Copy link
Member Author

It's a bit weird that it's timing out consistently with Vite 3 and wasn't with Vite 2. We should probably check that the test suite as a whole isn't taking a lot longer to run. But I guess if it's about the same overall there's no harm in bumping it

@eltigerchino
Copy link
Member

eltigerchino commented Jan 17, 2025

The test takes the same amount of time if not slightly longer with Vitest 2 (5400ms) https://github.com/sveltejs/kit/actions/runs/12821853458/job/35753837184?pr=13227#step:9:49 not sure why the timeout error only kicks in for Vitest 3

@benmccann
Copy link
Member Author

Weird, yeah, it looks like Vitest 2 was just ignoring the timeout. I had to bump it a bunch of places to get things passing. It's working now

@eltigerchino eltigerchino merged commit 702575e into main Jan 20, 2025
14 checks passed
@eltigerchino eltigerchino deleted the update-major-deps branch January 20, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants