Skip to content

chore: Resolve some random TODOs #13328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: Resolve some random TODOs #13328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/adapter-static/test/apps/prerendered/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "~TODO~",
"name": "adapter-static-test-prerendered",
"version": "0.0.1",
"private": true,
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/adapter-static/test/apps/spa/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "~TODO~",
"name": "adapter-static-test-spa",
"version": "0.0.1",
"private": true,
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/src/core/postbuild/prerender.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ async function prerender({ hash, out, manifest_path, metadata, verbose, env }) {
const { pathname, search, hash } = new URL(href, 'http://localhost');

if (search) {
// TODO warn that query strings have no effect on statically-exported pages
log.warn(`Query parameters in ${href} will have no affect on prerendering`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth adding a changeset for this?

}

if (hash) {
Expand Down
3 changes: 1 addition & 2 deletions packages/kit/src/exports/node/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ export async function setResponse(res, response) {
key,
key === 'set-cookie'
? set_cookie_parser.splitCookiesString(
// This is absurd but necessary, TODO: investigate why
/** @type {string}*/ (response.headers.get(key))
value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhhhm @gtm-nayan do you remember why exactly this was necessary? You added it in #9638 - want to make sure that not just using the value really was on purpose

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to test again to be exact but IIRC, there can be multiple set-cookie headers and how the value is returned with multiple of them, didn't work with how we use it here.

)
: value
);
Expand Down
9 changes: 0 additions & 9 deletions packages/kit/test/apps/basics/src/routes/load/unchanged-parent/+layout.svelte
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions packages/kit/test/apps/basics/src/routes/load/unchanged/+layout.svelte
View file
Open in desktop

This file was deleted.

Loading