feat: support writable sockets #13317
Open
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current the socket is created based on the umask (commonly `0022`), resulting in read only sockets. This change adds the env variable `SOCKET_PATH_IS_WRITABLE`, which configures `writableAll`, supporting writable sockets.
🦋 Changeset detectedLatest commit: 7aac0df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
preview: https://svelte-dev-git-preview-kit-13317-svelte.vercel.app/ this is an automated message |
|
See #12211 for original issue (cannot re-open on mobile for some reason). /cc @omkelderman This allows any user to perform requests against the socket e.g. needed when the web server and application are running under different uids. |
|
/cc @benmccann as the original reviewer |
eltigerchino
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current the socket is created based on the umask (commonly
0022), resulting in read only sockets.This change adds the env variable
SOCKET_PATH_IS_WRITABLE, which configureswritableAll, supporting writable sockets.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits