fix: await applyAction and goto

[GitRowin]

Here is a simple form with a button that gets disabled while the form is being submitted:

<form
  method="post"
  use:enhance={() => {
    sending = true;
    return async ({ update }) => {
      await update();
      sending = false;
    };
  }}
>
  <div>
    <button disabled={sending}>{sending ? "Sending..." : "Send"}</button>
  </div>
</form>

If the server responds with a redirect, I expect the button to stay on "Sending..." until the other page shows up. Unfortunately, this is not what happens right now: .

And here is what it looks like after these changes: .

---

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

• Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

[changeset-bot]

🦋 Changeset detected

Latest commit: d23e70b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Rich-Harris]

preview: https://svelte-dev-git-preview-kit-13032-svelte.vercel.app/

this is an automated message

[dummdidumm]

I think this makes sense. The question is what exactly happens if the redirect happens and then the code from the previos page runs. This could possibly also cause problems because it tries to change elements that are no longer there.

[f-elix]

if you're expecting a redirect, why bother changing sending to false at all? Can't you leave it to true until the page changes?

[GitRowin]

if you're expecting a redirect, why bother changing sending to false at all? Can't you leave it to true until the page changes?

Yep, it's just more boilerplate:

<form
  method="post"
  use:enhance={() => {
    sending = true;
    return async ({ result, update }) => {
      if (result.type !== "redirect") sending = false;
      update();
    };
  }}
>

And I figured you should be able to await update anyway.

[dummdidumm]

I think await applyAction(result) makes sense, but I'm not sure about this part anymore. It's basically guaranteeing that you're gonna run into a situation where you're likely to deal with dangling objects from the old page, and that could result in harder to debug issues compared to a spinner aborting too earlier, which can be worked around easily as shown in the discussion