-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for svelte.config.ts #12457
Conversation
🦋 Changeset detectedLatest commit: c5ed56c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Not sure about the others workflow error like playwright can't read or vercel. |
Looks like it's a flaky tests |
@@ -2,6 +2,8 @@ import fs from 'node:fs'; | |||
import path from 'node:path'; | |||
import * as url from 'node:url'; | |||
import options from './options.js'; | |||
import pkg from 'typescript'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would create a direct dependency from sveltekit to typescript, forcing everyone, even non-typescript users to install it. That's a big no.
Thanks, but I'm pretty sure this is insufficient. It only transpiles the config file, but as soon as that one imports other TS files you'll get errors. |
There has not been a consensus that support for svelte.config.ts is going to happen. If it was, it would have to be added at a different level (see discussion in the linked issue) as all tools in the svelte ecosystem would have to be able to read it |
I will think about other solutions later. |
Question added in RFC sveltejs/rfcs#59 @dominikg @dummdidumm |
This added support for
svelte.config.ts
with minimal changes and independent. This does not provide types support, however, now we could runsvelte.config.ts
out-of-the-box.Closes #2576
Note that,
svelte.config.js
is prioritized by default.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits