🐛 Use the today prop in isFutureDate/isPastDate calculations
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielstellini
changed the title
today prop for isFuture/isPast date calculations
gabrielstellini
changed the title
today prop for isFuture/isPast date calculationstoday prop in the isFuture/isPast date calculations
gabrielstellini
changed the title
today prop in the isFuture/isPast date calculationstoday prop in isFuture/isPast date calculations
gabrielstellini
changed the title
today prop in isFuture/isPast date calculationstoday prop in isFutureDate/isPastDate calculations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes?
Today is not the same everywhere around the world - (unfortunately) timezones exist :D
This change allows you to pass the
todayobject as a prop, and makes the isPast/isFuture function depend on itHow do we test?
Pass an arbitrary
todayvalue - it should effect the disabled dates in the datepicker