-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full model DAGMC faceting via CAD-to-DAGMC #180
base: main
Are you sure you want to change the base?
Conversation
8859e67
to
952dd5e
Compare
It should be noted that the "Regular CI testing for parastell / Perform CI Tests" workflow is failing because it is not pulling the Docker image corresponding to this branch |
@bquan0, do you know how to fix the issue mentioned in the above comment, concerning the proper image tag being used? |
It's because of this line. |
I figured as much! Just unsure how to go about retrieving the proper tag. Would it be done similarly to this line? |
Since "Build & publish Docker image for ParaStell CI / Test CI Image" runs our test suite when we've made changes to any file affecting our Docker image, I'm going to add a condition to "Regular CI testing for parastell / Perform CI Tests" that will prevent its execution (returning the "Success" status) should any of those aforementioned files be modified. In effect, this change will make it such that our CI testing will defer to "Build & publish Docker image for ParaStell CI / Test CI Image" to test the code under the condition that the Docker image has been modified. |
This branch adds support for a fully open-source, freely available DAGMC faceting workflow via CAD-to-DAGMC. This workflow is implemented as an alternative to the Cubit DAGMC faceting workflow.
Changes included in this branch:
Stellarator.export_cad_to_dagmc
method to automate DAGMC model generation via CAD-to-DAGMC and adds it to test and example scriptsStellarator.export_dagmc
method, which generates DAGMC models via Cubit, toStellarator.export_cf_dagmc
and updates syntax in test and example scriptsInVesselBuild.export_cad_to_dagmc
method as it is made redundant by theStellarator.export_cad_to_dagmc
method and removes it from test and example scriptsMagnetSet.coil_solids
parameter for future referenceIt should be noted that the CAD-to-DAGMC routine used here enforces that imprinting is skipped, since we have determined based on the way we create geometry that imprinting is unnecessary. It was found that CAD-to-DAGMC's imprinting routine was computationally expensive and required an unreasonable amount of memory for our geometries. Skipping this routine alleviates this computational cost and the meshing is performed in seconds.