Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use --call--module-type=all instead of --module #1065

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

ponkio-o
Copy link
Contributor

@ponkio-o ponkio-o commented Sep 17, 2024

Follow up following warning message:
CleanShot 2024-09-17 at 12 25 58

related: terraform-linters/tflint#2036 / terraform-linters/tflint#1951

@suzuki-shunsuke
Copy link
Owner

Thank you for your contribution!
We need to check the minimum required version of tflint for --call--module-type=all.

@ponkio-o
Copy link
Contributor Author

We need to check the minimum required version of tflint for --call--module-type=all.

That is certainly true!
But how to identify the version is troubling. I've come up with a way to parse result of tflint --version output, but there a better way?

@suzuki-shunsuke
Copy link
Owner

But how to identify the version is troubling. I've come up with a way to parse result of tflint --version output, but there a better way?

I meant to clarify the minimum required version in the release note and the document.

@ponkio-o
Copy link
Contributor Author

I meant to clarify the minimum required version in the release note and the document.

That's sounds good. I updated the README. Would you like this?
9ee40ab

@suzuki-shunsuke
Copy link
Owner

suzuki-shunsuke commented Sep 17, 2024

Seems like the option was added at v0.50.0 (Dec 23, 2023), not v0.51.0.

@ponkio-o
Copy link
Contributor Author

Sorry! Fixed it.
6fa8d64

@suzuki-shunsuke suzuki-shunsuke merged commit 4a32570 into suzuki-shunsuke:main Sep 19, 2024
1 check passed
@suzuki-shunsuke suzuki-shunsuke added this to the v2.0.0 milestone Sep 19, 2024
@ponkio-o ponkio-o deleted the patch-1 branch September 26, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants