-
Notifications
You must be signed in to change notification settings - Fork 53
Brench for ttrying a new approach #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ArnonAsquira
wants to merge
56
commits into
suvelocity:main
Choose a base branch
from
ArnonAsquira:brench-for-ttrying-a-new-approach
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Brench for ttrying a new approach #8
ArnonAsquira
wants to merge
56
commits into
suvelocity:main
from
ArnonAsquira:brench-for-ttrying-a-new-approach
+1,164
−4,870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creating the skeleton for future features to be implemented on
i made two event listeners for the list items for double click and blur
i've done a lot of trial and error with this function, which funally came to a decent result. but i'm still looking out for this function because it seems quite tricky
…ut in the different sections
i have restructured my code, and would alaborate on this change in greater detail in the readme file, and in future commits beacause the change was quite big and i would like to commit this change, an write about it in an ordered manner
i've added this functionality using iteration of the different sections' elements and hiding the elements which do not dit the search value. the current function has a lot of repeated code, which i will improve in the near future
… function to make the LI editable, this turned out to work better
…ementing with the api after a lot of trial error i have managed to succesfully use the PUT request of the API and i will continue to work on it in future commits
…m/ArnonAsquira/kanban-final into brench-for-ttrying-a-new-approach
…g to improve readability
also adding styles to the sorting buttons
this is my readMe file explaining my work process
…z sort now works boh ways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my main project brench, in this brench i've added all my additional features and put my best work in.
It has all the required features + additional features and styles.
however, this brench does not pass the tests, beacause it uses a different method of saving to the local storage.
In this brench i've saved entire ULs into to their relevant arrays in the local storage using outerHTML. I preffered this method beacause it is very convient and allows changes to be saved very easily and intiuitivly.
I have also made another brench which passes al 8 tests, which saves the data in the expected format