-
Notifications
You must be signed in to change notification settings - Fork 53
Upgraded code #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DanielPhilosoph
wants to merge
30
commits into
suvelocity:main
Choose a base branch
from
DanielPhilosoph:UpgradeCode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgraded code #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic structure of my page
Handling button clicks + done with adding tasks to LoacalStorage
Could now show the information in LocalStorage("task")
change key name to "tasks" in LocalStorage. Added search - working.
Added page css. Search wasn't insensitive - Fixed
Can change test with dbclick. Done
Changed edit text to pass the tests. Added a functionality of alt+number to move tasks from 1 section to another
API saving the tasks on bin - Done. User can load and save his tasks. **Dont pass tests yet
Handling empty tasks and duplicate tasks
Added right click, can now mark tasks as important or regular.
Can delete a task with right click
Naming, order and specific events per type
Cant drag and drop - cant sort yet. On click marks the task.
Every refresh remove add input values.
Can now delete tasks with backspace. Also fixed some code (removed important option)
Can drag and drop with sort option. Fixed add - couldn't show massage
Fixed, could sort in any way the user desire
Fixed position loader at save and load clicks
Not done yet
Adding ";" where needed, removing comments and spacing
This reverts commit 31b2a6b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section code, small functions - relative names