Re implement kanban #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added first structure to the page and the needed ids and classes
added code to addLiGeneric func, for now the dom in update when i click and also the local storage even after refresh , now i need to make sure the dom dont change after refresh
added searchFilter function to filter the li according to text we enter in the search bar
switched the newTaskData to use unshift instead of push . also called the search bar function searchFilter
passed the third test and verified it . i didnt passed cause i added a class name "li-task " to every li and i entered it inside a div and then assigned the div to the ul , doesnt pass !
basic structure of dblclick eventlistener request , still got to change the data in the local storage so after a refresh the change will remain
the dblclick function works ,but dont pass the test
wrote functions to deal with the 4 test , to move tasks between ul's (dom), and update the local storage according to the dom . also fixed the dblclick edit function by adding event listeners to the generateListItems function call in ChangeUl function (beacause the test move an li and straight trying to edit him).
fixed the serchFilter function and now i pass the search test .
added upload +save buttons and css ,the buttons doesnt work but its on the way to work . added favicon ,logo ,and other stuff
load and save buttons doesnt accure errors , fixed the request format.
built the save and load buttons functions. added event listeners to the buttons that call an async function with get and put requests . built the functions according to your requires , add a real hard time with these two last tests . luckily i have made it ! checked and verified the tests
added drag n drop functions . drag and drop between uls and drag and drop between tasks and trash can. used an trash image to drop tasks on him and then the task is deleted from all places(instead of the api if its there). changed favicon
changed the read me file , and last touches , removed one console.log check i left by mistake ,also gave liitle right push to the search bar.
separated my code to smaller functions and add little changes to have less rows(addtasks functions , storage functions , dblclick)
add several changes , separated some functions into smaller pieces
everytime i added a task i got multiply of tasks in the ul , fixed it .
webpack+eslint+prettier installed , also imported images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after re implement kanban verison , tried to separate the functions into smaller functions , and seperate the all code into different sections.