-
Notifications
You must be signed in to change notification settings - Fork 53
Aviv Yamin final #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AvivYamin
wants to merge
15
commits into
suvelocity:main
Choose a base branch
from
AvivYamin:AvivYamin-Final
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Aviv Yamin final #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s an action code from a sequence of target and action. each action code has a functional case to handle the wanted actions.
… by the add task function. That's in order to control the targets of the event listeners later on.
…sks object in the respective list(by the targeted button). The code initializes a check to see if there's an existing Tasks object in the local storage, if not it stores the default setting. Each action is stored and placed in the wanted place - element and array wise. I also created a button to load the DOM from the tasks saved in the local storage.
…pplied a condition in my handler that classifies the action and the class of the target, if the target is "task" then the handler executes a function that creates a new input on focus and changes the task's element value and stores it in the local storage.
…te while loop) I am committing the changes to start over
…y the search query. If the query does not matches the task text content than it block its display.
…ist. Once the event(hover over a task element) is triggered it adds an event listener to the document that waits for alt to be pressed and the specified keys. Then it replaces the item's list (removes it from the current one, erase it from the object, and assign it to the new list element and array). Eventually it removes the event listener and defines the task element to null.
… Once a click is triggered on "Load" it receives the data in the API bin, saves it in the local storage and regenerates the DOM. Once update button is clicked it receives the data in the local storage and fetches it to the API for storage. I also played with the CSS for a bit.
…p(the date they were created), a deadline that you choose from a hidden form that displays with an event listener, and you would be able to sort the tasks by their urgency (amount of days left until the deadline). However I could not finish the new feature on time so so I made it a dead code that I'll commit now but I will erase it later on for the final commit. It also ruined the tests for me so I will show the functionality in the video.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add a "Dates" feature however I didn't manage to do it due to time pressure.
You can notice the code of it in the 12th commit.