Check mission #34
Open
Check mission #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create function to get the right props from the correct id and return this title and etc, more function to set the duration to MMSS format
remove playlist
all create playlist tests, do them together because its like add song tests
play playlist!
the function get to be like others function we used before
added all the edit playlist function to the code
query search
added query to playlists
only searchbyduration of song is left
Finished without cleaning all the unnecessary code
arranged the functions,add regex to duration check, added test arguments function, and changed some of the names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go through the commits and see the way to the final Code.