Daniels branch #28
Open
Daniels branch #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the song with an identical ID from songs and playlists
Fixed test suvelocity#7 return id
removes a playlist if exists by ID
Creating playlist - test prove. added a part to generate id which can also generate ID for playlist as well
Fixing the ID check (if not a number throw ERR). Creating play playlist by given ID - uses the playSong function
added the function - pass all the test runs. Will work on side functions later on
The function calculate the number of seconds in a playlist. Also changed some notes
added the function, searching through songs and playlists and returns them back as an Object
search duration pass 1 test - the second should go too, working on it. moved calaPlayTime to be a function of its own
at "createPlaylist" moved isNan() to the top of the function, must check validation before everything else
Could not find if the first song was closest. Fixed
Added functions for code that repeats itself. Created a new area for those functions. Tests unharmed.
Changed check_Time_String_Validtion to void function. Added a check validation at add song to "duration"
Fixed TABS, ";", and useless functions. Readable code - haven't changed any logics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished