Yam mp3 second weekend task #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is update the code to make playSong(Id) print to the console a song by this way:"Playing {song.title} from {song.album} by {song.artist} | {song.duration}."
This commit also brings more 3 help functions to the code:
timeConventor(duration)
isIdExist(songs,id)
getSongFromId(songs, id)
this commit update the code by adding the function removeSong(id) that changes the player variable by removing the song from the list of songs and from the playlists. this commit adds 3 more help functions: removeSongFromPlayerById(songs , id) isExistOnPlaylist(playlists, id) removeFromPlaylistSongsList(songs , id)
this commit had 2 functions to the code. and add more functions that help the main functions: removeHelp numberForId timeConventorToSeconds this commit also fix isIdExist so it can work on songs and playlists and not only on songs.
this commit update the code and add two more main functions to the code. this commit also add help function to the code: returnPropItem
this commit add to the code the editPlaylist function. and also add help function: removeHelpForSongsOnPlaylists
adds a function that sum all songs duration that in the playlist id that the function gets. this commit also fix the problem the editPlaylist had with adding a help function: isIdExistInsidePlaylist
this commit updates the code by adding 2 function. also add 1 help function: serchForQuery(item , query) I also made comments on every function in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my pull request to submission the task.