-
Notifications
You must be signed in to change notification settings - Fork 55
Edit branch #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tsoriLache
wants to merge
27
commits into
suvelocity:master
Choose a base branch
from
tsoriLache:edit-branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Edit branch #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added removeSong func.
did it the same way as remove song also added findPlayList func.
added generatePlaylistId func. so also changed generateId to generateSongId
added createPlaylist func.
simillar to addSong
I accidentally changed the letters.
added playPlaylist simplly loop that use playSong
if the seconed were less than ten it would give 00:0 insted 00:00.
added editPlaylist func.
added playlistDuration func.
added searchByQuery func.
works...need check to see if could be improve
added checkDurationInput func. that checks if the durattion is in the correct format. apllyed it in functions that use duration as input
deleted unnecessary variables
sortByTitle sortByName both for searchByQuery func.
changed it so the format will be clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finished editing pass all tests.