-
Notifications
You must be signed in to change notification settings - Fork 54
Mp3 dom aviv yamin #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AvivYamin
wants to merge
17
commits into
suvelocity:main
Choose a base branch
from
AvivYamin:MP3-DOM-Aviv-Yamin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… create the functions in the index. However, I haven't finished them yet.
…reates a parent song element <div> and placed it inside a songs list (row 210). inside each song there's children(title, album...). the parent of the song is the list song, the parent of the list songs is the container and the list has a sibling of a header with a h2 as a child. I could not figure out how to pass the attribute from the object (missing one argument error)
…aying song and to log the details of the song
… and generate playlists
…Songs element and the player object
… value by name so I attached an ID to the inputs through for loops in order to get the value of the inputs. I placed these values into the add song function to add the new song from the inputs.
…ds which button was pressed by its class name and executes the relevant function playSong/removeSong. I also played with the CSS a bit.
…ground color to blue for the duration time of that specific song.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.