Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite clear instructions in Superwall SDK's docs to pass the application context to the
Superwall.configure()
method, given no type safe distinction between activity context and application context, it's possible to mistakenly pass an activity context, like in the example app. That can lead to memory leaks, as the SDK holds a reference to the context for its whole lifecycle that is longer than lifecycle of an Activity.It can also cause app crashes, for example when initialising
JavaScriptSandbox
after the activity is finished.Steps to reproduce the crash in Example application:
MainActivity
when navigating toHomeActivity
JavaScriptSandbox
afterMainActivity
is finished.Logs:
To avoid errors, the SDK can precautionary get application context from the context passed into
Superwall.configure()
method.Given that, the SDK requirements could get relaxed to allow initialisation with activity context.