-
Notifications
You must be signed in to change notification settings - Fork 14
fix: GHA #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.1
Are you sure you want to change the base?
fix: GHA #257
Conversation
echo "postgresql_config_version: 0" >> $CONFIG_FILE | ||
|
||
# verify api keys are passed | ||
if [ ! -z $API_KEYS ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition [ ! -z $API_KEYS ]
should be quoted as [ ! -z "$API_KEYS" ]
to properly handle values containing spaces. This pattern appears throughout the script and could lead to unexpected behavior when environment variables contain spaces. Consider updating all similar conditions in the script for more robust variable handling.
if [ ! -z $API_KEYS ] | |
if [ ! -z "$API_KEYS" ] |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)
Checklist for important updates
pluginInterfaceSupported.json
file has been updated (if needed)build.gradle
build.gradle
, please make sure to add themin
implementationDependencies.json
.git tag
) in the formatvX.Y.Z
, and then find thelatest branch (
git branch --all
) whoseX.Y
is greater than the latest released tag.OneMillionUsersTest
Remaining TODOs for this PR