feat: move base tenants plugin #12
Conversation
🦋 Changeset detectedLatest commit: 2bdfe62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
deepjyoti30-st
force-pushed
the
feat/base-tenants-plugin
branch
from
a4b8a42 to
bc24525
Compare
deepjyoti30-st
changed the base branch from
feat/tenant-discovery-plugin
to
main
deepjyoti30-st
force-pushed
the
feat/base-tenants-plugin
branch
from
d414eae to
e3a5f81
Compare
| enableDebugLogs(); | ||
| } | ||
|
|
||
| const baseProfilePlugin = plugins.find((plugin: any) => plugin.id === "supertokens-plugin-profile-base"); |
There was a problem hiding this comment.
I'd prefer that we use a separate base plugin (and thus a separate page).
There was a problem hiding this comment.
Not sure what you mean. Are you saying we should create a separate base plugin for tenants or just a different instance of the same plugin 🤔 ?
Also, don't we want tenant related UI to be part of the same profile details UI (where other user details can be managed)?
There was a problem hiding this comment.
Discussed this - decided we don't need it right now but keeping it open for Mihaly to remember that this could be considered in the future.
packages/tenants-react/src/pages/select-tenant/TenantWrapper.tsx
Outdated
Show resolved
Hide resolved
…ertokens/supertokens-plugins into feat/base-tenants-plugin
No description provided.