Log raw graphql responses when they don't unmarshal correctly#3
Open
Log raw graphql responses when they don't unmarshal correctly#3
Conversation
yogeshgadge
reviewed
Apr 23, 2025
yogeshgadge
left a comment
There was a problem hiding this comment.
IMO it should not print anything and treat as logf potentially including granular level type = ERROR. This is because others might want logs written in their own fashion. There is a convenient Log hook for that.
I might suggest using c.logf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the json output doesn't match the struct layout, it prints the raw json response in the error for debugging reasons.
The response pretty-prints and indents the json with a pipe symbol, it looks something like this:
(it used to be
Error: decoding response: json: cannot unmarshal object into Go struct field[xyz] of type [jkl])Relevant context: superfly/flyctl#1866